Skip to content

[FLINK-39114][filesystem] Support configurable timeout in native-s3-fs#27904

Open
Samrat002 wants to merge 2 commits intoapache:masterfrom
Samrat002:FLINK-39114-configurable-timeout
Open

[FLINK-39114][filesystem] Support configurable timeout in native-s3-fs#27904
Samrat002 wants to merge 2 commits intoapache:masterfrom
Samrat002:FLINK-39114-configurable-timeout

Conversation

@Samrat002
Copy link
Copy Markdown
Contributor

@Samrat002 Samrat002 commented Apr 8, 2026

What is the purpose of the change

This pull request makes hardcoded timeout values in the Native S3 FileSystem configurable via Flink configuration options. Previously, timeouts for HTTP connections, socket reads, connection idle time, filesystem close, and client close were hardcoded constants. From an operational standpoint, these should be tunable to accommodate different network environments and deployment scenarios.

Brief change log

  • Added 4 new ConfigOption fields:
    1. s3.connection.timeout, s3.socket.timeout
    2. s3.connection.max-idle-time
    3. s3.close.timeout
    4. s3.client.close.timeout
  • Default values match the previous hardcoded values (no behavior change without explicit configuration)

Verifying this change

  • Added testCustomTimeoutConfiguration in NativeS3FileSystemFactoryTest that creates a filesystem with all custom timeout values and verifies successful creation

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: yes

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? JavaDocs

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Apr 8, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Samrat002 Samrat002 force-pushed the FLINK-39114-configurable-timeout branch from 9223b3c to f7555a3 Compare April 8, 2026 13:16
Copy link
Copy Markdown

@spuru9 spuru9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@github-actions github-actions bot added the community-reviewed PR has been reviewed by the community. label Apr 8, 2026
Copy link
Copy Markdown
Contributor

@Izeren Izeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change @Samrat002, I suggest we use Duration type to follow standard Flink approach for time based configurations

@Samrat002 Samrat002 requested a review from Izeren April 9, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants