[kv] Add an implementation of AutoIncIDBuffer #2161
+951
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beryllw
force-pushed
the
auto-inc-impl
branch
2 times, most recently
from
45dc38a to
4d674d7
Compare
xx789633
reviewed
Dec 12, 2025
fluss-common/src/main/java/org/apache/fluss/metadata/Schema.java
Outdated
Show resolved
Hide resolved
fluss-common/src/test/java/org/apache/fluss/metadata/TableDescriptorTest.java
Show resolved
Hide resolved
xx789633
reviewed
Dec 12, 2025
fluss-server/src/main/java/org/apache/fluss/server/kv/autoinc/SegmentIDGenerator.java
Outdated
Show resolved
Hide resolved
Contributor
|
hi, I had created this Pr: #2119 for this issue. Do we want to prefer this one over that? |
Contributor
|
Hi @vamossagar12 , we prefer this one to work on since it is more comprehensive. |
beryllw
force-pushed
the
auto-inc-impl
branch
2 times, most recently
from
19d0475 to
697dbcf
Compare
xx789633
reviewed
Dec 24, 2025
fluss-server/src/main/java/org/apache/fluss/server/utils/TableDescriptorValidation.java
Outdated
Show resolved
Hide resolved
xx789633
reviewed
Dec 24, 2025
fluss-common/src/main/java/org/apache/fluss/utils/json/ColumnJsonSerde.java
Outdated
Show resolved
Hide resolved
xx789633
reviewed
Dec 24, 2025
fluss-common/src/main/java/org/apache/fluss/config/ConfigOptions.java
Outdated
Show resolved
Hide resolved
beryllw
commented
Dec 25, 2025
| new Column( | ||
| column.getName(), | ||
| column.getDataType().copy(false), | ||
| column.getDataType().copy(true), |
Contributor
Author
There was a problem hiding this comment.
Partial update is required, so the data type here needs to be temporarily set to nullable.
beryllw
changed the title
xx789633
reviewed
Dec 25, 2025
fluss-server/src/main/java/org/apache/fluss/server/kv/autoinc/AutoIncProcessor.java
Outdated
Show resolved
Hide resolved
xx789633
reviewed
Dec 25, 2025
fluss-server/src/main/java/org/apache/fluss/server/zk/data/ZkData.java
Outdated
Show resolved
Hide resolved
platinumhamburg
suggested changes
Dec 29, 2025
Contributor
platinumhamburg
left a comment
platinumhamburg
left a comment
There was a problem hiding this comment.
@beryllw Thanks for contribution, I left some comments.
fluss-server/src/main/java/org/apache/fluss/server/zk/ZkSequenceIDCounter.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/kv/autoinc/AutoIncProcessor.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/kv/autoinc/AutoIncProcessor.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/kv/autoinc/IncIDGenerator.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/kv/autoinc/SegmentSequenceGenerator.java
Show resolved
Hide resolved
platinumhamburg
suggested changes
Dec 29, 2025
fluss-client/src/test/java/org/apache/fluss/client/table/FlussTableITCase.java
Show resolved
Hide resolved
fluss-common/src/main/java/org/apache/fluss/config/ConfigOptions.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/kv/KvTablet.java
Outdated
Show resolved
Hide resolved
Contributor
|
In addition to integration tests, I think we should also add several unit tests in KvTabletTest to cover behavior assertions after a TabletServer restart and after a single segment overflows. |
Contributor
Author
We could create a new issue to address the failover problem, including the design and implementation of its corresponding recovery mechanisms. |
platinumhamburg
suggested changes
Dec 31, 2025
fluss-server/src/main/java/org/apache/fluss/server/kv/autoinc/IncIDGenerator.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/kv/autoinc/SegmentIncIDGenerator.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/kv/autoinc/AutoIncProcessor.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/kv/KvTablet.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/kv/autoinc/AutoIncColumnProcessor.java
Outdated
Show resolved
Hide resolved
xx789633
requested review from
wuchong
and removed request for
platinumhamburg
platinumhamburg
suggested changes
Jan 7, 2026
fluss-server/src/main/java/org/apache/fluss/server/kv/KvTablet.java
Outdated
Show resolved
Hide resolved
platinumhamburg
suggested changes
Jan 7, 2026
Contributor
platinumhamburg
left a comment
platinumhamburg
left a comment
There was a problem hiding this comment.
I've left some additional comments.
fluss-client/src/test/java/org/apache/fluss/client/table/FlussFailServerTableITCase.java
Outdated
Show resolved
Hide resolved
fluss-client/src/test/java/org/apache/fluss/client/table/FlussTableITCase.java
Outdated
Show resolved
Hide resolved
fluss-client/src/test/java/org/apache/fluss/client/table/FlussTableITCase.java
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/kv/autoinc/AutoIncProcessor.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/kv/autoinc/AutoIncProcessor.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/kv/autoinc/AutoIncProcessor.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/kv/autoinc/AutoIncProcessor.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/kv/autoinc/AutoIncProcessor.java
Outdated
Show resolved
Hide resolved
platinumhamburg
suggested changes
Jan 8, 2026
fluss-server/src/main/java/org/apache/fluss/server/kv/autoinc/AutoIncProcessor.java
Outdated
Show resolved
Hide resolved
…alone interface and removing stateful coupling in AutoIncProcessor
platinumhamburg
suggested changes
Jan 8, 2026
fluss-server/src/main/java/org/apache/fluss/server/kv/autoinc/AutoIncProcessor.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/kv/autoinc/AutoIncProcessor.java
Outdated
Show resolved
Hide resolved
platinumhamburg
approved these changes
Jan 8, 2026
Contributor
platinumhamburg
left a comment
platinumhamburg
left a comment
There was a problem hiding this comment.
LGTM, @wuchong Do you have any other suggestions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2111
Brief change log
Tests
API and Format
Documentation