[spark] Fix column projection on log/upsert read path#3057
Open
fresh-borzoni wants to merge 1 commit intoapache:mainfrom
Open
[spark] Fix column projection on log/upsert read path#3057fresh-borzoni wants to merge 1 commit intoapache:mainfrom
fresh-borzoni wants to merge 1 commit intoapache:mainfrom
Conversation
fresh-borzoni
force-pushed
the
fix/spark-projection-type-dependent
branch
from
e3c79fb to
378beea
Compare
Contributor
Author
|
@luoyuxia @YannByron @Yohahaha PTAL 🙏 |
fresh-borzoni
force-pushed
the
fix/spark-projection-type-dependent
branch
from
378beea to
264a955
Compare
fresh-borzoni
force-pushed
the
fix/spark-projection-type-dependent
branch
from
264a955 to
8ac8103
Compare
Yohahaha
approved these changes
Apr 11, 2026
Contributor
Yohahaha
left a comment
Yohahaha
left a comment
There was a problem hiding this comment.
overall LGTM! left one comments, thank you!
Comment on lines
+36
to
+41
| private lazy val projectedRowType = rowType.project(projection) | ||
|
|
||
| override protected def convertToSparkRow(flussRow: FlussInternalRow): InternalRow = { | ||
| DataConverter.toSparkInternalRow(flussRow, projectedRowType) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
could we move these common func to FlussPartitionReader?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FlussPartitionReader.rowType uses the full table schema, but scanners return projected rows with shifted ordinals. Type-dependent accessors in FlussAsSparkRow dispatch via rowType.getTypeAt(ordinal), so projected queries on TIMESTAMP/ARRAY/STRUCT columns get a ClassCastException. Override convertToSparkRow in both subclasses to use the projected row type, and stop double-projecting in SortMergeReader.
closes #3029