chore: fix docs for RustFS AssumeRole#3058
Open
fresh-borzoni wants to merge 2 commits intoapache:mainfrom
Open
chore: fix docs for RustFS AssumeRole#3058fresh-borzoni wants to merge 2 commits intoapache:mainfrom
fresh-borzoni wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@luoyuxia @leekeiabstraction PTAL 🙏 |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Fluss quickstart and S3 filesystem documentation to reflect the RustFS STS AssumeRole support (introduced in #2989), removing the prior workaround that disabled KV snapshots and documenting the required AssumeRole configuration for S3-compatible backends.
Changes:
- Replaces the prior
kv.snapshot.interval: 0sworkaround in RustFS-based quickstarts withs3.region+ AssumeRole STS settings. - Adds/expands S3 filesystem docs covering S3-compatible endpoints (RustFS/MinIO) and AssumeRole STS configuration.
- Updates Flink quickstart narrative to link to the new AssumeRole STS documentation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| website/docs/quickstart/lakehouse.md | Updates RustFS compose examples to include s3.region + AssumeRole STS settings and removes the snapshot-disable workaround. |
| website/docs/quickstart/flink.md | Updates RustFS compose examples similarly and adds a doc link explaining AssumeRole STS requirements. |
| website/docs/maintenance/filesystems/s3.md | Adds S3-compatible storage guidance plus an AssumeRole STS configuration section for delegation-token dependent features. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@luoyuxia Ty, addressed Copilot comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR fixes the RustFS STS workaround introduced in #2660. That PR disabled KV snapshots (kv.snapshot.interval: 0s) because RustFS doesn't support GetSessionToken. Now that #2989 added AssumeRole support, we can re-enable snapshots by configuring the AssumeRole STS settings instead.
Also adds S3 filesystem documentation for S3-compatible storage and AssumeRole configuration