[VL] Refactor Velox metrics transport to use JSON payloads#12126
Open
rui-mo wants to merge 1 commit into
Open
Conversation
rui-mo
force-pushed
the
wip_metrics_refactor
branch
from
8755a20 to
f05b72a
Compare
rui-mo
force-pushed
the
wip_metrics_refactor
branch
from
f05b72a to
ae23dbe
Compare
rui-mo
force-pushed
the
wip_metrics_refactor
branch
from
ae23dbe to
465e90e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Refactors Velox metrics transport away from fragile JNI long-array plumbing to a structured JSON payload decoded on the Scala side.
Replace the long Metrics JNI constructor with a stable metricsJson, numMetrics, veloxToArrow, and taskStats payload.
Move native metric field mapping and custom runtime metric extraction into MetricsUtil.scala.
Making future metric additions mostly Scala-side changes.
Keep C++ responsible only for exporting ordered Velox operator stats and task stats metadata.
Adds MetricsFramework.md documentation.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?