[GOBBLIN-2169] Fix NPE while overwrite if table has no previous snapshot#4071
Merged
Will-Lo merged 1 commit intoapache:masterfrom Oct 31, 2024
Merged
Conversation
Will-Lo
approved these changes
Oct 31, 2024
phet
reviewed
Oct 31, 2024
Comment on lines
239
to
240
| public List<DataFile> getPartitionSpecificDataFiles(Predicate<StructLike> icebergPartitionFilterPredicate) | ||
| throws IOException { |
Contributor
There was a problem hiding this comment.
wouldn't the last line here also throw an NPE for the same reason?
public List<DataFile> getPartitionSpecificDataFiles(Predicate<StructLike> icebergPartitionFilterPredicate)
throws IOException {
TableMetadata tableMetadata = accessTableMetadata();
Snapshot currentSnapshot = tableMetadata.currentSnapshot();
long currentSnapshotId = currentSnapshot.snapshotId();
looking quickly at this class, there are several places that are not resilient to the unexpected circumstance of a table having existing and metadata, but not actually any snapshots yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
While overwrite we log the snapshot id of last snapshot present before commit but in case of table with no snapshot (possible freshly created table) currentSnapshot will be null hence will give NPE if used to fetch SnapshotId
This PR fixes that with proper logging.
Tests
NA
Commits