Optimize file discovery by adding skipPermissionCheck flag#4162
Open
thevyom1 wants to merge 1 commit intoapache:masterfrom
Open
Optimize file discovery by adding skipPermissionCheck flag#4162thevyom1 wants to merge 1 commit intoapache:masterfrom
thevyom1 wants to merge 1 commit intoapache:masterfrom
Conversation
- Added skipPermissionCheck flag to skip I/O operations for files that already exist in the target location - When enabled, skips expensive file status checks and permission resolutions for existing files - Improves performance for discovery by avoiding unnecessary I/O operations - Disabled by default to maintain backward compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
This PR introduces a performance optimization for file discovery by adding a
skipPermissionCheckflag.Key changes:
skipPermissionCheckflag to skip I/O operations for files that already exist in the target locationThis change is particularly beneficial for large-scale copy operations where file existence checks can be a significant performance bottleneck.
Tests
Commits