HDFS-17929. Revisit retrying mechanism in DFSStripedInputStream#8524
Open
CapMoon wants to merge 1 commit into
Open
HDFS-17929. Revisit retrying mechanism in DFSStripedInputStream#8524CapMoon wants to merge 1 commit into
CapMoon wants to merge 1 commit into
Conversation
Contributor
Author
|
@ZanderXu @hfutatzhanghb masters, can take a look at this mr when you are available |
Member
Thanks for reporting and involving me here. Will review this laterly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
DFSStripedInputStream#createBlockReader handles reader creation failures by re-fetching the block location, because the striped internal block may have moved. However, after re-fetching it unconditionally calls addToLocalDeadNodes().
There is also a related retry issue in DFSStripedInputStream#readWithStrategy. The method retries after an IOException, but the next blockSeekTo() can still use cached LocatedBlocks. Without refreshing open file information before retrying, the retry may reuse stale block locations and hit the same moved-block condition again.
How was this patch tested?
Unit tests