HDFS-17561. Make HeartbeatManager.Monitor use up-to-date heartbeatRecheckInterval#8541
Open
kokonguyen191 wants to merge 3 commits into
Open
HDFS-17561. Make HeartbeatManager.Monitor use up-to-date heartbeatRecheckInterval#8541kokonguyen191 wants to merge 3 commits into
kokonguyen191 wants to merge 3 commits into
Conversation
ZanderXu
reviewed
Jun 11, 2026
ZanderXu
left a comment
ZanderXu
left a comment
Contributor
There was a problem hiding this comment.
Make sense. Leave some comments.
| private volatile long heartbeatIntervalSeconds; | ||
| private volatile int heartbeatRecheckInterval; | ||
| /** Used by {@link HeartbeatManager}. */ | ||
| private volatile long heartbeatRecheckIntervalForMonitor; |
Contributor
There was a problem hiding this comment.
How about moving it to HeartbeatManager?
| } | ||
|
|
||
| @VisibleForTesting | ||
| public void refreshHeartbeatRecheckIntervalForMonitor() { |
Contributor
There was a problem hiding this comment.
Move this method to HeartbeatManager and just change it if heartbeatRecheckInterval is changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
(rebased and reopened due to being auto close some time back)
DatanodeManager can changes heartbeatRecheckInterval via reconf API but HeartbeatManager's copy of heartbeatRecheckInterval is fixed at initialization and won't update when DatanodeManager updates with a new config.