HBASE-29787 Run static checks to a Github Action #7566

ndimiduk · 2025-12-19T11:17:46Z

No description provided.

ndimiduk · 2025-12-19T18:11:11Z

I think this is working. Please help me out by double-checking that the checks run by the new system have parity with the jenkins build.

Apache9 · 2025-12-20T09:06:57Z

I think this is working. Please help me out by double-checking that the checks run by the new system have parity with the jenkins build.

Let's just try it on a special branch? Scripts are always hard to review...

Apache9 · 2025-12-20T09:08:52Z

Ah, I saw the checks, let me check the result...

Apache9 · 2025-12-20T09:11:19Z

Seems we missed lots of checks...

+1 overall
Vote	Subsystem	Runtime	Log	Comment
Prechecks
+1	dupname	0m 0s		No case conflicting files found.
+1	@author	0m 0s		The patch does not contain any @author tags.
master Compile Tests
+1	spotless	0m 53s		branch has no errors when running spotless:check.
Patch Compile Tests
+1	codespell	0m 13s		No new issues.
+1	detsecrets	4m 22s		No new issues.
+1	blanks	0m 0s		The patch has no blanks issues.
+1	yamllint	0m 0s		No new issues.
+1	spotless	0m 35s		patch has no errors when running spotless:check.
Other Tests
+1	asflicense	0m 11s		The patch does not generate ASF License warnings.
6m 27s		
Subsystem	Report/Notes
GITHUB PR	https://github.com/apache/hbase/pull/7566
Optional Tests	dupname asflicense codespell detsecrets yamllint spotless
uname	Linux 5359e6d56b16 6.11.0-1018-azure #18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/github/workspace/src/dev-support/hbase-personality.sh
git revision	master / efb501962294022f359c4cba545386ca4c78c7e9
modules	C: . U: .
versions	git=2.34.1 maven=3.9.9 codespell=2.4.1 detsecrets=1.5.0 yamllint=1.35.1
Powered by	Apache Yetus 0.16.0-SNAPSHOT https://yetus.apache.org
This message was automatically generated.

.github/workflows/yetus-general-check.yml

This reverts commit 1475173. This argument is required by the jenkins script

github-actions · 2025-12-29T14:57:45Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 7s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	yamllint	0m 0s		yamllint was not available.
-1 ❌	@author	0m 0s	/results-author.txt	The patch appears to contain 1 @author tags which the community has agreed to not allow in code contributions.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 26s		master passed
+1 💚	compile	8m 53s		master passed
+1 💚	checkstyle	2m 1s		master passed
+1 💚	spotbugs	8m 17s		master passed
+1 💚	spotless	0m 44s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 3s		the patch passed
+1 💚	compile	8m 51s		the patch passed
+1 💚	javac	8m 51s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 55s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	spotbugs	8m 19s		the patch passed
+1 💚	hadoopcheck	9m 8s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
-1 ❌	spotless	0m 7s		patch has 34 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
-1 ❌	asflicense	0m 19s	/results-asflicense.txt	The patch generated 1 ASF License warnings.
		62m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: /Dockerfile
GITHUB PR	#7566
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs spotless yamllint javac spotbugs checkstyle compile hadoopcheck hbaseanti
uname	Linux a694d06c83b4 6.11.0-1018-azure #18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `bdd7a4b`
Default Java	Eclipse Adoptium-17.0.11+9
spotless	/patch-spotless.txt
Max. process+thread count	159 (vs. ulimit of 30000)
modules	C: hbase-annotations . U: .
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

This reverts commit 83aeb87.

github-actions · 2025-12-29T16:09:22Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 8s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	yamllint	0m 0s		yamllint was not available.
-1 ❌	@author	0m 0s	/results-author.txt	The patch appears to contain 1 @author tags which the community has agreed to not allow in code contributions.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 45s		master passed
+1 💚	compile	9m 9s		master passed
+1 💚	checkstyle	1m 57s		master passed
+1 💚	spotbugs	8m 23s		master passed
+1 💚	spotless	0m 48s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 1s		the patch passed
+1 💚	compile	9m 4s		the patch passed
+1 💚	javac	9m 4s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 53s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	spotbugs	8m 26s		the patch passed
+1 💚	hadoopcheck	9m 12s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 40s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 19s		The patch does not generate ASF License warnings.
		63m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: /Dockerfile
GITHUB PR	#7566
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs spotless yamllint javac spotbugs checkstyle compile hadoopcheck hbaseanti
uname	Linux 9bc299901a7c 6.11.0-1018-azure #18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2ae9d69`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	160 (vs. ulimit of 30000)
modules	C: hbase-annotations . U: .
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

github-actions · 2025-12-29T17:25:01Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 8s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	yamllint	0m 0s		yamllint was not available.
-1 ❌	@author	0m 0s	/results-author.txt	The patch appears to contain 1 @author tags which the community has agreed to not allow in code contributions.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 19s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 52s		master passed
+1 💚	compile	10m 16s		master passed
+1 💚	checkstyle	2m 4s		master passed
+1 💚	spotbugs	9m 34s		master passed
+1 💚	spotless	0m 50s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 24s		the patch passed
+1 💚	compile	10m 18s		the patch passed
+1 💚	javac	10m 18s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	2m 1s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	spotbugs	9m 21s		the patch passed
+1 💚	hadoopcheck	9m 45s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 21s		The patch does not generate ASF License warnings.
		69m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: /Dockerfile
GITHUB PR	#7566
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs spotless yamllint javac spotbugs checkstyle compile hadoopcheck hbaseanti
uname	Linux 0712f285cd99 6.11.0-1018-azure #18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6f1edd5`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	162 (vs. ulimit of 30000)
modules	C: hbase-annotations . U: .
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-12-29T20:24:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	yamllint	0m 0s		yamllint was not available.
-1 ❌	@author	0m 0s	/results-author.txt	The patch appears to contain 1 @author tags which the community has agreed to not allow in code contributions.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 34s		master passed
+1 💚	compile	8m 31s		master passed
+1 💚	checkstyle	2m 18s		master passed
+1 💚	spotbugs	7m 30s		master passed
+1 💚	spotless	0m 48s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 9s		the patch passed
+1 💚	compile	8m 27s		the patch passed
+1 💚	javac	8m 26s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	2m 15s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	spotbugs	7m 46s		the patch passed
+1 💚	hadoopcheck	12m 4s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 45s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 19s		The patch does not generate ASF License warnings.
		66m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/14/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7566
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs spotless yamllint javac spotbugs checkstyle compile hadoopcheck hbaseanti
uname	Linux b0aa54a609ec 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6f1edd5`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	193 (vs. ulimit of 30000)
modules	C: hbase-annotations . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/14/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

This comment has been minimized.

Sign in to view

ndimiduk changed the title ~~HBASE-29787 Move static checks to a Github Action~~ HBASE-29787 Run static checks to a Github Action Dec 19, 2025

This comment has been minimized.

Sign in to view

ndimiduk marked this pull request as ready for review December 19, 2025 18:09

ndimiduk requested review from Apache9, NihalJain, charlesconnell, petersomogyi and stoty December 19, 2025 18:10

Apache9 reviewed Dec 20, 2025

View reviewed changes

.github/workflows/yetus-general-check.yml Outdated Show resolved Hide resolved

ndimiduk added 19 commits December 29, 2025 14:45

pin to a feature branch for dev purposes

1816df3

maybe address yamllint issues

58b8e57

only on PRs for now

b2fb0a0

add missing statuses:write

4dc79e0

drop unsupported paramteres

9a7aed8

go "under the hood" to enable personality features

bef466d

missing env maybe

4bc0b93

needs write access

55d0de3

fix yaml lints

2689611

more yaml formatting

fa0789c

use yetus:0.15.0

0304835

do as the jenkinsfile does

8d1d661

use the same fetch script as jenkinsfile

7feebf8

introduce some breakages

83aeb87

maybe fix output path for uploads

724f4e2

GH won't let us deep-link to artifact results

01a7a07

Revert "GH won't let us deep-link to artifact results"

8c2a484

This reverts commit 1475173. This argument is required by the jenkins script

BUILD_URL_ARTIFACTS only for actions

884cd89

try out nightlies secrets

9f4a4a4

ndimiduk force-pushed the 29787-gh-actions-static branch from c43c61b to 9f4a4a4 Compare December 29, 2025 13:46

use existing rsync binary with ssh-agent

bdd7a4b

This comment has been minimized.

Sign in to view

ndimiduk added 2 commits December 29, 2025 16:04

tweak rsync paths

404f67a

Revert "introduce some breakages"

2ae9d69

This reverts commit 83aeb87.

try again with the deployer action

6f1edd5

This comment has been minimized.

Sign in to view

HBASE-29787 Run static checks to a Github Action #7566

Are you sure you want to change the base?

HBASE-29787 Run static checks to a Github Action #7566

Uh oh!

Conversation

ndimiduk commented Dec 19, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ndimiduk commented Dec 19, 2025

Uh oh!

Apache9 commented Dec 20, 2025

Uh oh!

Apache9 commented Dec 20, 2025

Uh oh!

Apache9 commented Dec 20, 2025

Uh oh!

Uh oh!

This comment has been minimized.

github-actions bot commented Dec 29, 2025

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

This comment has been minimized.

Apache-HBase commented Dec 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants