HBASE-29776: Log filtering in IncrementalBackupManager can lead to data loss

[hgromer]

cc @DieterDP-ng @krconv

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 29s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	3m 25s		master passed
+1 💚	compile	0m 32s		master passed
+1 💚	checkstyle	0m 13s		master passed
+1 💚	spotbugs	0m 31s		master passed
+1 💚	spotless	0m 50s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 56s		the patch passed
+1 💚	compile	0m 30s		the patch passed
-0 ⚠️	javac	0m 30s	/results-compile-javac-hbase-backup.txt	hbase-backup generated 2 new + 127 unchanged - 0 fixed = 129 total (was 127)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 12s		the patch passed
-1 ❌	spotbugs	0m 38s	/new-spotbugs-hbase-backup.html	hbase-backup generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 💚	hadoopcheck	11m 23s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 45s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 11s		The patch does not generate ASF License warnings.
		29m 54s

Reason	Tests
SpotBugs	module:hbase-backup
	Dead store to newTimestamps in org.apache.hadoop.hbase.backup.impl.IncrementalBackupManager.getIncrBackupLogFileMap() At IncrementalBackupManager.java:org.apache.hadoop.hbase.backup.impl.IncrementalBackupManager.getIncrBackupLogFileMap() At IncrementalBackupManager.java:[line 63]
	org.apache.hadoop.hbase.backup.impl.IncrementalBackupManager.getIncrBackupLogFileMap() makes inefficient use of keySet iterator instead of entrySet iterator At IncrementalBackupManager.java:keySet iterator instead of entrySet iterator At IncrementalBackupManager.java:[line 92]

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7582/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7582
JIRA Issue	HBASE-29776
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 03a6ae72fd23 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 7ad60d2
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7582/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 15s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	2m 54s		master passed
+1 💚	compile	0m 16s		master passed
+1 💚	javadoc	0m 13s		master passed
+1 💚	shadedjars	4m 40s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 22s		the patch passed
+1 💚	compile	0m 16s		the patch passed
+1 💚	javac	0m 16s		the patch passed
+1 💚	javadoc	0m 11s		the patch passed
+1 💚	shadedjars	4m 41s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	12m 18s		hbase-backup in the patch passed.
		29m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7582/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7582
JIRA Issue	HBASE-29776
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 9b0e7fafe2f6 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 7ad60d2
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7582/1/testReport/
Max. process+thread count	3878 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7582/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.