Skip to content

HBASE-29909 RegionMover ignores configuration passed via -D on the command line #7767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
junegunn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HBASE-29909 RegionMover ignores configuration passed via -D on the command line #7767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,11 @@ public RegionMoverBuilder(String hostname) {
* Creates a new configuration and sets region mover specific overrides
*/
private static Configuration createConf() {
Configuration conf = HBaseConfiguration.create();
final Configuration conf = HBaseConfiguration.create();
return overrideConf(conf);
}

private static Configuration overrideConf(Configuration conf) {
conf.setInt("hbase.client.prefetch.limit", 1);
conf.setInt("hbase.client.pause", 500);
conf.setInt("hbase.client.retries.number", 100);
Expand All @@ -208,7 +212,7 @@ public RegionMoverBuilder(String hostname, Configuration conf) {
}
this.filename = defaultDir + File.separator + System.getProperty("user.name") + this.hostname
+ ":" + Integer.toString(this.port);
this.conf = conf;
this.conf = overrideConf(new Configuration(conf));
}

/**
Expand Down Expand Up @@ -947,7 +951,7 @@ protected void addOptions() {
@Override
protected void processOptions(CommandLine cmd) {
String hostname = cmd.getOptionValue("r");
rmbuilder = new RegionMoverBuilder(hostname);
rmbuilder = new RegionMoverBuilder(hostname, getConf());
this.loadUnload = cmd.getOptionValue("o").toLowerCase(Locale.ROOT);
if (cmd.hasOption('m')) {
rmbuilder.maxthreads(Integer.parseInt(cmd.getOptionValue('m')));
Expand Down