Fix incorrect pool reference in h2_request_rcreate#630
Open
joesuf4 wants to merge 2 commits intoapache:trunkfrom
Open
Fix incorrect pool reference in h2_request_rcreate#630joesuf4 wants to merge 2 commits intoapache:trunkfrom
joesuf4 wants to merge 2 commits intoapache:trunkfrom
Conversation
segfaults on certain subrequests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two serious h2 bugs:
First one involves the way h2 defers r->pool cleanups until the connection closes. This is simply insane, with a one-line repair to tie r->pool to the rcreate pool instead of the long-lived stream pool. This is trivially DOSable by someone with a clue.
Second one avoids a segfault during certain kinds of subrequest lookup processing.