feat(spark): refresh parquet tools clustering strategy for current master#18409
Open
suryaprasanna wants to merge 2 commits intoapache:masterfrom
Open
feat(spark): refresh parquet tools clustering strategy for current master#18409suryaprasanna wants to merge 2 commits intoapache:masterfrom
suryaprasanna wants to merge 2 commits intoapache:masterfrom
Conversation
Collaborator
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18409 +/- ##
=============================================
- Coverage 68.21% 44.32% -23.89%
+ Complexity 27709 16852 -10857
=============================================
Files 2440 2380 -60
Lines 134249 127070 -7179
Branches 16179 14562 -1617
=============================================
- Hits 91578 56328 -35250
- Misses 35565 65910 +30345
+ Partials 7106 4832 -2274
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
|
@nsivabalan Executing any parquet tools operations special jar to be included in the runtime, so I am not adding the column nullifying parquet tools execution strategy. Let us just keep the test class itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
This PR refreshes the parquet-tools based clustering strategy from the older
parquet-toolsbranch so it can be proposed against currentapache/master.The original implementation had drifted from current Hudi internals and test APIs. This refresh keeps the existing simple rewrite hook shape while aligning the implementation with current clustering and storage behavior.
Summary and Changelog
Refresh the parquet-tools clustering strategy and its supporting tests for current master.
ParquetToolsExecutionStrategyAPI simple with the existing file-to-file rewrite hookStoragePath/HoodieStoragebased APIsFSUtils.getCommitTime(...)Impact
No public API change intended.
This keeps the existing parquet-tools rewrite extension point, but makes it compatible with current Hudi master and current clustering output semantics.
Risk Level
low
The change is localized to the parquet-tools rewrite path and related test scaffolding.
Documentation Update
none
Contributor's checklist