feat: implement update column #498
Open
+1,117
−136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
requested changes
Jan 16, 2026
src/iceberg/update/update_schema.cc
Outdated
| ICEBERG_BUILDER_ASSIGN_OR_RETURN(auto field_opt, FindFieldForUpdate(name)); | ||
|
|
||
| // If not found, check if there's a deleted field with this name | ||
| if (!field_opt.has_value()) { |
Member
There was a problem hiding this comment.
Why not directly error out? The Java impl does not check original field.
Contributor
Author
There was a problem hiding this comment.
This is to distinguish between conflicting types, whether columns do not exist at all, or whether deleted columns are updated. I will modify the logic of FindFieldForUpdate to no longer check the delete list, but check and return the corresponding conflict information in UpdateColumns, which is consistent with java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.