refactor(rest): Switch HttpClient to use connection pool #530
+35
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeartLinked
force-pushed
the
rest/connectionpool
branch
from
1fe6861 to
505ddbe
Compare
wgtmac
reviewed
Jan 23, 2026
| wrapdb_version = 1.14.1-1 | ||
|
|
||
| [provide] | ||
| cpr = cpr_dep |
evindj
reviewed
Jan 24, 2026
| patch_fallback_url = https://github.com/mesonbuild/wrapdb/releases/download/cpr_1.14.1-1/cpr_1.14.1-1_patch.zip | ||
| patch_hash = e5930186aa8cfb9383a468a80d177b3a4c4fcc5f38deb6fca13d96263ce36459 | ||
| wrapdb_version = 1.14.1-1 | ||
|
|
There was a problem hiding this comment.
I assume the bump of version is due to the fact that 1.12 did not support connection pooling? I would probably add a little it of a comment on that in the summary just to help people get more context.
I assume integration tests are going to help catch any potential regression not directly related to this change?
Member
There was a problem hiding this comment.
TBH, it would be better to split this into two separate PRs, one for bumping the cpr version, the other for connection pool refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.