fix(upsert): early rejection of unsupported join column types#3384
Open
abnobdoss wants to merge 6 commits into
Open
fix(upsert): early rejection of unsupported join column types#3384abnobdoss wants to merge 6 commits into
abnobdoss wants to merge 6 commits into
Conversation
…pdate error expectations
…in key The error message renders the type from the Iceberg table's pyarrow schema, and schema_to_pyarrow converts pa.list_ into pa.large_list (see pyiceberg/io/pyarrow.py). The test regex must match the rendered large_list<element: int32>, not the source list<item: int32>.
A pa.null() source column was being rejected by _check_pyarrow_schema_compatible (format-version=2 forbids null) before the join-column validation could surface the intended "Null-type column ... cannot be used as a join key" error. Reordering the checks lets the upsert-specific rejection fire first, giving users the actionable message. Dataframe-level checks now skip columns that are absent from the source so the pre-existing _check_pyarrow_schema_compatible path still owns the "PyArrow table contains more columns" error in test_key_cols_misaligned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This is the first in a planned series of PRs to improve the stability and speed of the
Table.upsertoperation. This PR focuses on improving the correctness foundations by implementing "Fail Fast" validation for join key types.By rejecting unsupported types upfront, we prevent two major classes of issues:
This establishes a safe contract for the subsequent performance-focused PRs (Vectorization and Anti-Join de-duplication).
Are these changes tested?
Yes. I have added a comprehensive suite of parameterized tests in
tests/table/test_upsert.py.Are there any user-facing changes?
Yes. The
Table.upsertmethod now includes strict type validation for the join columns a user provides.For full disclosure - this PR was developed with the assistance of an AI coding assistant (Antigravity) to help refine the type-safety checks and edge-case validation.