fix: SqlCatalogBuilder does not save supplied name in SqlCatalogConfig before initializing SqlCatalog #2079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackmwk
approved these changes
Jan 30, 2026
Contributor
blackmwk
left a comment
blackmwk
left a comment
There was a problem hiding this comment.
Thanks @brodiealexander for this fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There hasn't been any movement on #1991 for a while so I wanted to see if I could help out. I'm not sure what the correct way of trying to continue where another PR left off is, so please let me know if there is a better way of going about this!
Which issue does this PR close?
Closes #1990
Refer to PR #1991
What changes are included in this PR?
Changes to SqlCatalogBuilder from #1991 are included but the new_sql_catalog function has been refactored to accept an optional name parameter. Relevant tests have been adjusted accordingly.
Are these changes tested?
Yes, refer to #1991 for cornerwings' added test. I've run the local
make testand everything seems to check out.Thanks!
Brodie