feat!(catalog): adding support for purge_table#2232
Open
CTTY wants to merge 10 commits intoapache:mainfrom
Open
feat!(catalog): adding support for purge_table#2232CTTY wants to merge 10 commits intoapache:mainfrom
CTTY wants to merge 10 commits intoapache:mainfrom
Conversation
CTTY
commented
Mar 12, 2026
geruh
reviewed
Mar 14, 2026
CTTY
changed the title
blackmwk
reviewed
Mar 20, 2026
| /// S3 Tables data is managed by the service, so this just delegates | ||
| /// to `drop_table` | ||
| async fn purge_table(&self, table: &TableIdent) -> Result<()> { | ||
| self.drop_table(table).await |
Contributor
There was a problem hiding this comment.
I think we should throw error here. If s3table doesn't support purge, we should report it rather than silently fail
Collaborator
Author
There was a problem hiding this comment.
S3 Tables doesn't support purge=false, so drop_table and purge_table should behave the same.
The "correct" way would be throwing error in drop_table and I think that's too inconvenient
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Catalog#2133What changes are included in this PR?
purge_tabletoCatalogtrait and add default implementationAre these changes tested?
Added new tests in table_suite