feat(storage): Implement ObjectStoreStorage::S3#2257
Draft
CTTY wants to merge 2 commits intoapache:mainfrom
Draft
feat(storage): Implement ObjectStoreStorage::S3#2257CTTY wants to merge 2 commits intoapache:mainfrom
CTTY wants to merge 2 commits intoapache:mainfrom
Conversation
CTTY
changed the title
wasifaleem
reviewed
Mar 22, 2026
| if config.allow_anonymous { | ||
| builder = builder.with_skip_signature(true); | ||
| } | ||
|
|
There was a problem hiding this comment.
not sure if this is in scope of the pr, but it would be great if we could attach a custom tokio runtime handle to spawn io tasks, something along the lines of
if let Some(handle) = io_runtime {
builder = builder.with_http_connector(SpawnedReqwestConnector::new(handle));
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?