chore(refactor) refactor manifest list writer to take Box<dyn FileWrite> to prep for encryption#2564
Open
xanderbailey wants to merge 5 commits into
Open
Conversation
…te> to prep for encryption
xanderbailey
force-pushed
the
xb/refactor_manifest_list_writer
branch
from
eeb7f21 to
3a5e3a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Working towards: #2034
What changes are included in this PR?
Change
ManifestListWriterto take aBox<dyn FileWrite>in the constructor rather than anOutputFile. For encryption support we haveEncryptedOutputFilewhich has aBox<dyn FileWrite>for transparent streaming encryption on write.Are these changes tested?