ci: Skip hf ci properly#2572
Open
CTTY wants to merge 1 commit into
Open
Conversation
blackmwk
reviewed
Jun 3, 2026
Contributor
There was a problem hiding this comment.
I don't understand why we need this workflow, the secrets is supposed to be stored in repos. If there is no such secrets, we should not even run this.
Collaborator
Author
There was a problem hiding this comment.
I also don't quite get it. maybe @kszucs will have more context.
I'm +1 on removing the workflow until we get a free account for the CI to make things consistent
But I think we should proceed with the existing changes to at least skip the CI properly
| @@ -73,8 +95,8 @@ jobs: | |||
| cdc-python: | |||
Contributor
There was a problem hiding this comment.
Also why this is specially treated? Why not run with other python test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
.github/workflows/ci_hf_cdc.yml: No jobs were runWhat changes are included in this PR?
Add an extra step to check the secrets
Are these changes tested?
In the CI check down below, we should see HF tests properly skipped instead of sending an email