Split manifest_list into smaller modules#2577
Merged
Merged
Conversation
Contributor
Author
|
Really thanks @xanderbailey for introducing the public api check and we could be confiident that such refactoring will not introduce unnecessary breaking api changes. |
xanderbailey
approved these changes
Jun 3, 2026
Contributor
xanderbailey
left a comment
xanderbailey
left a comment
There was a problem hiding this comment.
Very nice change, thanks for the refactor!
CTTY
approved these changes
Jun 3, 2026
Collaborator
CTTY
left a comment
CTTY
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the refactoring
Collaborator
|
The CI seems to fail with zizmor, I believe this is addressed by another fix: https://github.com/apache/iceberg-rust/pull/2578/changes Merging it now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
manifest_listmodule to a dir module. #2569 .What changes are included in this PR?
Split manifest_list module into smaller onces so that it's easier to maintain. There is no breaking changes.
Are these changes tested?
ci.