Expose failed commit count and exceptions in BaseCommitService#14871
Closed
erkanonl wants to merge 1 commit intoapache:mainfrom
Closed
Expose failed commit count and exceptions in BaseCommitService#14871erkanonl wants to merge 1 commit intoapache:mainfrom
erkanonl wants to merge 1 commit intoapache:mainfrom
Conversation
Expose failed commit count and exceptions in BaseCommitService
Author
|
Closing in favour of #14872 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change do?
This PR adds lightweight tracking for failed commit attempts in BaseCommitService.
Specifically, it:
Why is this change needed?
BaseCommitService explicitly supports partial progress, but today failed commits are only logged.
This makes it difficult to:
This change improves observability without altering commit behavior or public APIs.
Scope and compatibility
The change is limited to BaseCommitService, which is package-private and internal
No behavioral changes to commit execution or error handling
No impact on existing public APIs