Do not fail if no partitions assigned#15955
Open
kumarpritam863 wants to merge 30 commits intoapache:mainfrom
Open
Do not fail if no partitions assigned#15955kumarpritam863 wants to merge 30 commits intoapache:mainfrom
kumarpritam863 wants to merge 30 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@bryanck @danielcweeks can you please review. |
| @@ -70,7 +70,7 @@ class Coordinator extends Channel { | |||
| private static final Logger LOG = LoggerFactory.getLogger(Coordinator.class); | |||
| private static final ObjectMapper MAPPER = new ObjectMapper(); | |||
| private static final String COMMIT_ID_SNAPSHOT_PROP = "kafka.connect.commit-id"; | |||
| private static final String TASK_ID_SNAPSHOT_PROP = "kafka.connect.task-id"; | |||
| private static final String COORDINATOR_ID_SNAPSHOT_PROP = "kafka.connect.coordinator-id"; | |||
Contributor
There was a problem hiding this comment.
This rename feels like an unnecessary clarification. They both really mean the same thing and updating an existing property causes more problems than it's worth. It's assumed that that the task identified is the coordinator.
Contributor
Author
There was a problem hiding this comment.
@danielcweeks I completely agree with you. Will revert these changes.
Comment on lines
+122
to
+132
| /** | ||
| * Finds the first (minimum) topic partition across all consumer group members. | ||
| * | ||
| * <p>The "first" partition is determined using {@link TopicPartitionComparator}, which orders | ||
| * {@link TopicPartition} instances lexicographically by topic name and, for equal topics, by | ||
| * ascending partition number. | ||
| * | ||
| * @param members the collection of consumer group members | ||
| * @return the first topic partition according to {@link TopicPartitionComparator}, or null if no | ||
| * partitions are assigned | ||
| */ |
Contributor
There was a problem hiding this comment.
I don't think we need this documentation. The behavior is evident and this isn't publicly facing.
Contributor
Author
There was a problem hiding this comment.
@danielcweeks I added these for future devs contributing to have reference to this but will revert these as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This #14395 removed the client side stability check of the consumer group (which is rightly done). But since we have removed the check there will be more instances of invalid calls (class when rebalance is going on or happening frequently) and we should wait for the final rebalance to happen and simply return false.