Spark, Hive: Fix snapshot procedure for tables with Variant columns#15964
Open
nssalian wants to merge 2 commits intoapache:mainfrom
Open
Spark, Hive: Fix snapshot procedure for tables with Variant columns#15964nssalian wants to merge 2 commits intoapache:mainfrom
nssalian wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
Author
Contributor
|
@nssalian will do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #14123 and #15220 too.
Summary
The
snapshotprocedure fails on Spark tables with Variant columns because the Hive catalog storesLazySimpleSerDeinstead ofParquetHiveSerDefor these tables. The SerDe-based format detection doesn't recognize it and throws.After fixing that, a second failure occurs when running the test provided in the issue,
HiveSchemaUtil.convertToTypeStringwhich has no case for VARIANT.Changes
This adds a
resolveFileFormathelper that falls back totable.provider()when the SerDe doesn't match a known format, and maps VARIANT to "unknown" in the Hive schema conversion, following the conversation here: #15228Made changes in Spark v4.0 and v4.1
Test plan
HiveSchemaUtilconversion check