API: Relax partition name check when source column is dropped#15967
Merged
huaxingao merged 1 commit intoapache:mainfrom Apr 14, 2026
Merged
Conversation
Skip the identity name pairing when the partition source id no longer resolves in the schema, so historical specs do not block re-adding a column with the same name. Add API and Spark extension tests.
RussellSpitzer
commented
Apr 13, 2026
| Types.NestedField schemaField = | ||
| this.caseSensitive ? schema.findField(name) : schema.caseInsensitiveFindField(name); | ||
| if (checkConflicts) { | ||
| if (sourceColumnId != null) { |
Member
Author
There was a problem hiding this comment.
I flipped this around because I kept getting confused now its
- Normal case, no source id
- Checking for partition transforms with source id (like identity)
singhpk234
approved these changes
Apr 14, 2026
dramaticlly
approved these changes
Apr 14, 2026
Contributor
|
Thanks @RussellSpitzer for the PR! Thanks @singhpk234 @dramaticlly for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip the identity name pairing when the partition source id no longer resolves in the schema, so historical specs do not block re-adding a column with the same name. Add API and Spark extension tests.
Used Cursor - Claude-4.6-opus-high