Kafka Connect :: Remove iceberg.connect.group.id config and derive it from consumer group ID#15969
Open
kumarpritam863 wants to merge 29 commits intoapache:mainfrom
Open
Conversation
Contributor
Author
|
@danielcweeks can you please review this. |
Contributor
Author
|
@bryanck I have marked the prop as deprecated. Can you review once. |
Contributor
Author
|
@danielcweeks can you please take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current implementation requires users to set a separate
iceberg.connect.group.idconfiguration that must match the source consumer group ID (consumer.override.group.id/group.id) for the Kafka Connect coordinator to be elected correctly.This has caused significant confusion and bugs among developers and users since the beginning, including:
connect.group.idor setting it incorrectlyProblematic scenario example:
consumer.override.group.id = "x-1"consumer.override.group.id = "cg"connect.group.id = "x-1"Result:
Even though the actual consumer group IDs are different (
cgvsx-1) for job B, the coordinator election still happens based onconnect.group.id = "x-1". This leads to:Solution
This PR:
connect.group.idconfiguration completelygroup.id/consumer.override.group.id)connectGroupId→sourceConsumerGroupIdfor clarity (in code/comments where applicable)Benefits
Breaking Change
No – Even if "iceberg.connect.group.id" is set, it will be ignored and the correct value will be derived from the consumer group id.