Data: Add TCK coverage for reader default values#16638
Draft
joyhaldar wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Joy Haldar <joy.haldar@target.com>
joyhaldar
commented
May 31, 2026
| Arguments.of(Types.DoubleType.get(), Literal.of(-0.0D)), | ||
| Arguments.of(Types.DateType.get(), Literal.of(DateTimeUtil.isoDateToDays("2024-12-17"))), | ||
| Arguments.of( | ||
| Types.TimeType.get(), Literal.of(DateTimeUtil.isoTimeToMicros("23:59:59.999999"))), |
Contributor
Author
There was a problem hiding this comment.
Re-enabled the TIME case here, it passes for AVRO and PARQUET, ORC skips. It was added commented out in DataTestBase, I haven't traced why, so flagging in case it was intentional.
pvary
reviewed
Jun 1, 2026
| .map(generator -> Arguments.of(format, generator))) | ||
| .toList(); | ||
|
|
||
| private static final List<Arguments> PRIMITIVE_TYPES_AND_DEFAULTS = |
Contributor
There was a problem hiding this comment.
Could we use a DataGenerator for this?
Contributor
Author
There was a problem hiding this comment.
The matrix is (type, default-literal) pairs and the test asserts the reader injects exactly that literal, so the type has to stay paired with its expected value. DataGenerator is one schema() + random rows, so it can't carry that pairing, at least as I understand the current interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the reader default-value tests from DataTestBase into the Base Format model TCK: