Core: Relative paths for manifest list#16651
Draft
rambleraptor wants to merge 1 commit into
Draft
Conversation
rambleraptor
changed the title
huan233usc
reviewed
Jun 1, 2026
| return JsonUtil.parse(json, SnapshotParser::fromJson); | ||
| } | ||
|
|
||
| private static String resolveManifestList(String manifestList, String tableLocation) { |
There was a problem hiding this comment.
nit: should we consider using Optional? (personally I don't like play with nulls)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm starting out small, but this adds support for relative paths for a manifest-list. If this looks good, I can make some larger changes in future PRs.