Kafka Connect: Precompute UUID-as-bytes flag in RecordConverter#16654
Open
wombatu-kun wants to merge 1 commit into
Open
Kafka Connect: Precompute UUID-as-bytes flag in RecordConverter#16654wombatu-kun wants to merge 1 commit into
wombatu-kun wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RecordConverter.convertUUIDrecomputedFileFormat.PARQUET.name().toLowerCase(Locale.ROOT).equals(config.writeProps().get(DEFAULT_FILE_FORMAT))for every UUID-typed value. The write file format is fixed for the converter's lifetime (writePropsis set once on the config), so this boolean is constant, yetenum.name()+toLowerCaseallocated a fresh"parquet"String on every call, plus a map lookup and an equals.This resolves the flag once in the constructor (
writeUuidAsBytes), reducingconvertUUIDto a field read. Behavior is unchanged: the same 16-byte representation is returned for Parquet and the same UUID otherwise.A throwaway A/B microbench over the whole
convertUUIDmethod (2M iterations x 9 trials, median; baseline mirrors the current inline expression, optimized uses the precomputed boolean) showed the per-value cost drop:That is roughly 20-27 ns saved per UUID value, about 40% of the method on String inputs (the common Kafka Connect case). The numbers are indicative wall-clock from a microbench, not JMH.
Existing
TestRecordConvertercovers the conversion (includingtestUUIDConversionWithParquet); its mock now defaultswriteProps()to an empty map to mirror production, where it is never null.