Fix Docker build for actions with multi-step builds#685
Open
potiuk wants to merge 1 commit intorefactor/verify-action-build-modularizefrom
Open
Fix Docker build for actions with multi-step builds#685potiuk wants to merge 1 commit intorefactor/verify-action-build-modularizefrom
potiuk wants to merge 1 commit intorefactor/verify-action-build-modularizefrom
Conversation
The elif chain in the Dockerfile build step stopped after the first successful command. Actions like matlab-actions/setup-matlab v3 need both "npm run build" (tsc → lib/) and "npm run package" (ncc → dist/). Replace the elif chain with a loop that checks for output after each step and continues until dist/ has JS files. Fixes verification failures in #667 and #668. Generated-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 9, 2026
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tsc→lib/thenncc build→dist/)elifchain stopped after the first successful build command even if it didn't produce output in the expected directorydist/has filesnpm run build(tsc) succeeds but outputs tolib/, notdist/Verified
uv run utils/verify-action-build.py matlab-actions/setup-matlab@c6998d116f15now passes (bothcache-save/index.jsandsetup/index.jsshow as identical)Test plan
🤖 Generated with Claude Code