You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds a configurable cache for PathUtils#checkAndReturnSingleMeasurement so repeated measurement validation can reuse previous check results. The cache stores both valid and invalid validation results and can be disabled by setting the cache size to 0.
It also adds configuration plumbing for integration tests and an ignored performance IT that can be run manually to compare end-to-end write performance with the cache disabled and enabled.
❌ Patch coverage is 51.35135% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.75%. Comparing base (1d8b23a) to head (d011d05). ⚠️ Report is 26 commits behind head on master.
I think this part has a correctness issue: checkTsFileResourceExists currently warns for every .tsfile because it only checks the filename suffix and never checks whether the corresponding resource file exists. For a normal snapshot containing both xxx.tsfile and xxx.tsfile.resource, this still logs The associated resource file ... is not found in the snapshot, which is a false warning. Please check
ew File(file.getAbsolutePath() + TsFileResource.RESOURCE_SUFFIX).exists() before warning, or remove this unrelated snapshot change from this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a configurable cache for
PathUtils#checkAndReturnSingleMeasurementso repeated measurement validation can reuse previous check results. The cache stores both valid and invalid validation results and can be disabled by setting the cache size to0.It also adds configuration plumbing for integration tests and an ignored performance IT that can be run manually to compare end-to-end write performance with the cache disabled and enabled.
Test Report
Local verification:
Performance averages, 3 repeats per group, 80,000 rows per experiment: