Bump the maven-patch-group group across 1 directory with 2 updates#3976
Bump the maven-patch-group group across 1 directory with 2 updates#3976dependabot[bot] wants to merge 1 commit into
Conversation
Bumps the maven-patch-group group with 2 updates in the / directory: [org.eclipse.jetty:jetty-bom](https://github.com/jetty/jetty.project) and [org.eclipse.jetty.ee11:jetty-ee11-bom](https://github.com/jetty/jetty.project). Updates `org.eclipse.jetty:jetty-bom` from 12.1.9 to 12.1.10 - [Release notes](https://github.com/jetty/jetty.project/releases) - [Commits](jetty/jetty.project@jetty-12.1.9...jetty-12.1.10) Updates `org.eclipse.jetty.ee11:jetty-ee11-bom` from 12.1.9 to 12.1.10 - [Release notes](https://github.com/jetty/jetty.project/releases) - [Commits](jetty/jetty.project@jetty-12.1.9...jetty-12.1.10) Updates `org.eclipse.jetty.ee11:jetty-ee11-bom` from 12.1.9 to 12.1.10 - [Release notes](https://github.com/jetty/jetty.project/releases) - [Commits](jetty/jetty.project@jetty-12.1.9...jetty-12.1.10) --- updated-dependencies: - dependency-name: org.eclipse.jetty:jetty-bom dependency-version: 12.1.10 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: maven-patch-group - dependency-name: org.eclipse.jetty.ee11:jetty-ee11-bom dependency-version: 12.1.10 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: maven-patch-group - dependency-name: org.eclipse.jetty.ee11:jetty-ee11-bom dependency-version: 12.1.10 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: maven-patch-group ... Signed-off-by: dependabot[bot] <support@github.com>
|
The Jetty upgrade breaks digest authentication, probably because Jena's implementation is following the original RFC. |
|
Probably Jena's digest authentication has kept up with RFC's. |
|
I looked at this (with an LLM) and did some tests on what was minimal to pass the tests, and I think using the query, together with the path, while also setting the algorithm is enough to make the tests pass. Note that sometimes it seemed to intermittently fail also. See main...OyvindLGjesdal:jena:dependabot/maven/maven-patch-group-52fd5e174b Not very confident here with the code and me understanding the full context. I ran The LLM also suggested changing the starting value for the nonce to 1 (as per the RFC) as well as adding a header, but those didn't fix or change the failing tests (commented them out, rebuilt and reran tests successfully). I guess a proper long term fix would be to change the implementation to use a recommended algorithm? |
|
Yes, the nonce needs to start from >0. The code is using MD5 with no algorithm header which is now wrong. The simple fix is to switch to hashing with SHA-256 (required, default). But as changes are happening, the code could handle the "algorithm=" parameter and the possible multiple I think Jetty only sends one Maybe a direct fix now and refinement later! Issue #3977. PS |
Bumps the maven-patch-group group with 2 updates in the / directory: org.eclipse.jetty:jetty-bom and org.eclipse.jetty.ee11:jetty-ee11-bom.
Updates
org.eclipse.jetty:jetty-bomfrom 12.1.9 to 12.1.10Release notes
Sourced from org.eclipse.jetty:jetty-bom's releases.
Commits
9860245Updating to version 12.1.106d62879IteratingCallback concurrent abort() may not notify abort event. (#15185)962f73fFixes #15009 - Make processing of RST_STREAM more lenient. (#15087)6324c65#15180 upgrade quiche to version 0.29.1d0bb829Fixes #15136 - Refresh Digest authentication implementation.ac73ac1Issue #14522 Bundle org.eclipse.jetty.websocket.server OSGI metadata should e...206c2e6Merge pull request #15179 from jetty/fix/jetty-12.1.x/14745-MultiPartCleanup8d86494Merge pull request #15163 from jetty/fix/jetty-12.1.x/15161-HttpConnectionOpt...437e617Merge pull request #15178 from jetty/fix/jetty-12.1.x/14006-ReadPendingWarnings577d932Issue #14745 - fix race for double call of HttpChannelState.completeStream (1...Updates
org.eclipse.jetty.ee11:jetty-ee11-bomfrom 12.1.9 to 12.1.10Release notes
Sourced from org.eclipse.jetty.ee11:jetty-ee11-bom's releases.
Commits
9860245Updating to version 12.1.106d62879IteratingCallback concurrent abort() may not notify abort event. (#15185)962f73fFixes #15009 - Make processing of RST_STREAM more lenient. (#15087)6324c65#15180 upgrade quiche to version 0.29.1d0bb829Fixes #15136 - Refresh Digest authentication implementation.ac73ac1Issue #14522 Bundle org.eclipse.jetty.websocket.server OSGI metadata should e...206c2e6Merge pull request #15179 from jetty/fix/jetty-12.1.x/14745-MultiPartCleanup8d86494Merge pull request #15163 from jetty/fix/jetty-12.1.x/15161-HttpConnectionOpt...437e617Merge pull request #15178 from jetty/fix/jetty-12.1.x/14006-ReadPendingWarnings577d932Issue #14745 - fix race for double call of HttpChannelState.completeStream (1...Updates
org.eclipse.jetty.ee11:jetty-ee11-bomfrom 12.1.9 to 12.1.10Release notes
Sourced from org.eclipse.jetty.ee11:jetty-ee11-bom's releases.
Commits
9860245Updating to version 12.1.106d62879IteratingCallback concurrent abort() may not notify abort event. (#15185)962f73fFixes #15009 - Make processing of RST_STREAM more lenient. (#15087)6324c65#15180 upgrade quiche to version 0.29.1d0bb829Fixes #15136 - Refresh Digest authentication implementation.ac73ac1Issue #14522 Bundle org.eclipse.jetty.websocket.server OSGI metadata should e...206c2e6Merge pull request #15179 from jetty/fix/jetty-12.1.x/14745-MultiPartCleanup8d86494Merge pull request #15163 from jetty/fix/jetty-12.1.x/15161-HttpConnectionOpt...437e617Merge pull request #15178 from jetty/fix/jetty-12.1.x/14006-ReadPendingWarnings577d932Issue #14745 - fix race for double call of HttpChannelState.completeStream (1...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions