KAFKA-20389: Filter internal keys from connector plugin config REST response#21976
KAFKA-20389: Filter internal keys from connector plugin config REST response#21976nileshkumar3 wants to merge 5 commits intoapache:trunkfrom
Conversation
| @JsonProperty("dependents") List<String> dependents | ||
| @JsonProperty("dependents") List<String> dependents, | ||
| @JsonProperty("internal") boolean internal | ||
| ) { |
There was a problem hiding this comment.
@mimaison Since ConfigKeyInfo is a public API class and adding a new record component changes its constructor signature, does this change require a KIP? The REST API change is additive (new internal field in JSON), but Java clients constructing ConfigKeyInfo directly would break.
There was a problem hiding this comment.
ConfigKeyInfo is not part of the public API. You can see all the public API classes in https://kafka.apache.org/42/javadoc/index.html
There was a problem hiding this comment.
Thanks @mimaison, this is helpful. request your review on this PR.
|
I'm not sure this change makes sense. See my comment in https://issues.apache.org/jira/browse/KAFKA-20389 |
nileshkumar3
changed the title
Changed the code as per the comment. request another round of review. |
2 participants
The GET /connector-plugins/{plugin}/config response used to list every key from the plugin’s ConfigDef, including internal ones. Internal keys are now filtered out, so clients only see keys that are meant to be user-facing.