Skip to content

#AI COMMIT# Add Dependabot ignore rules for Flink shims modules#5441

Merged
casionone merged 1 commit into
masterfrom
chore/configure-dependabot-ignore-rules
Jun 11, 2026
Merged

#AI COMMIT# Add Dependabot ignore rules for Flink shims modules#5441
casionone merged 1 commit into
masterfrom
chore/configure-dependabot-ignore-rules

Conversation

@aiceflower

Copy link
Copy Markdown
Member

Dependabot has raised PRs (#5426, #5427) that upgrade Flink dependencies from 1.16.2 to 1.20.4 inside flink-shims-1.16.2. This is incorrect because shims modules are version-specific compatibility layers — the module name must match the supported engine version. Upgrading the dependency in-place would break the shims contract and likely cause compilation or runtime failures across 4 major Flink versions.

The correct approach to support a newer Flink version is to create a new shims module (e.g. flink-shims-1.20.4) following the existing pattern, rather than modifying the existing flink-shims-1.16.2 module.

What is the purpose of the change

EngineConn-Core defines the the abstractions and interfaces of the EngineConn core functions.
The Engine Service in Linkis 0.x is refactored, EngineConn will handle the engine connection
and session management.

Related issues/PRs

Related issues: close #590 close #591
Related pr:#591

Brief change log

  • Define the core abstraction and interfaces of the EngineConn Factory;
  • Define the core abstraction and interfaces of Executor Manager.

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

Dependabot has raised PRs (#5426, #5427) that upgrade Flink dependencies
from 1.16.2 to 1.20.4 inside flink-shims-1.16.2. This is incorrect
because shims modules are version-specific compatibility layers — the
module name must match the supported engine version. Upgrading the
dependency in-place would break the shims contract and likely cause
compilation or runtime failures across 4 major Flink versions.

The correct approach to support a newer Flink version is to create a
new shims module (e.g. flink-shims-1.20.4) following the existing
pattern, rather than modifying the existing flink-shims-1.16.2 module.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

@casionone casionone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@casionone casionone merged commit dd8d342 into master Jun 11, 2026
10 of 22 checks passed
@casionone casionone deleted the chore/configure-dependabot-ignore-rules branch June 11, 2026 08:21
aiceflower added a commit to aiceflower/linkis that referenced this pull request Jun 15, 2026
…he#5441)

Dependabot has raised PRs (apache#5426, apache#5427) that upgrade Flink dependencies
from 1.16.2 to 1.20.4 inside flink-shims-1.16.2. This is incorrect
because shims modules are version-specific compatibility layers — the
module name must match the supported engine version. Upgrading the
dependency in-place would break the shims contract and likely cause
compilation or runtime failures across 4 major Flink versions.

The correct approach to support a newer Flink version is to create a
new shims module (e.g. flink-shims-1.20.4) following the existing
pattern, rather than modifying the existing flink-shims-1.16.2 module.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
aiceflower added a commit to aiceflower/linkis that referenced this pull request Jun 15, 2026
…he#5441)

Dependabot has raised PRs (apache#5426, apache#5427) that upgrade Flink dependencies
from 1.16.2 to 1.20.4 inside flink-shims-1.16.2. This is incorrect
because shims modules are version-specific compatibility layers — the
module name must match the supported engine version. Upgrading the
dependency in-place would break the shims contract and likely cause
compilation or runtime failures across 4 major Flink versions.

The correct approach to support a newer Flink version is to create a
new shims module (e.g. flink-shims-1.20.4) following the existing
pattern, rather than modifying the existing flink-shims-1.16.2 module.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
aiceflower added a commit to WeDataSphere/linkis that referenced this pull request Jun 15, 2026
…he#5441)

Dependabot has raised PRs (apache#5426, apache#5427) that upgrade Flink dependencies
from 1.16.2 to 1.20.4 inside flink-shims-1.16.2. This is incorrect
because shims modules are version-specific compatibility layers — the
module name must match the supported engine version. Upgrading the
dependency in-place would break the shims contract and likely cause
compilation or runtime failures across 4 major Flink versions.

The correct approach to support a newer Flink version is to create a
new shims module (e.g. flink-shims-1.20.4) following the existing
pattern, rather than modifying the existing flink-shims-1.16.2 module.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
aiceflower added a commit to WeDataSphere/linkis that referenced this pull request Jun 16, 2026
…he#5441)

Dependabot has raised PRs (apache#5426, apache#5427) that upgrade Flink dependencies
from 1.16.2 to 1.20.4 inside flink-shims-1.16.2. This is incorrect
because shims modules are version-specific compatibility layers — the
module name must match the supported engine version. Upgrading the
dependency in-place would break the shims contract and likely cause
compilation or runtime failures across 4 major Flink versions.

The correct approach to support a newer Flink version is to create a
new shims module (e.g. flink-shims-1.20.4) following the existing
pattern, rather than modifying the existing flink-shims-1.16.2 module.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants