[Security] Temporarily disable master branch protection for sensitive data cleanup#5443
Merged
Merged
Conversation
… cleanup To clean sensitive information (internal IPs, passwords, internal domains) from historical commits per security ticket, master branch needs to be force-pushable. The cleanup is required for: * Internal IPs (e.g., 10.x.x.x, 172.21.x.x) -> 127.0.0.1 * Database passwords (e.g., bdpVsbi@2019) -> default * Internal domains (e.g., weoa.com) -> localhost * Database names (e.g., vsbi_gz_bdap_sit_01) -> default_db The protection rule will be restored in a follow-up PR after the cleanup. This is the same mechanism used previously (see commits 9d8fd03, 831d80b, 613c3b8 for reference).
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
GitHub branch protection on
masterprevents force-push, which is required to clean sensitive information leaked in historical commits per the security ticket.The following sensitive data needs to be cleaned from the git history:
10.107.x.x,172.21.x.x) →127.0.0.1bdpVsbi@2019,bdpeasyide@bdpsit) →defaultweoa.com) →localhostvsbi_gz_bdap_sit_01) →default_dbWhat this PR does
Comments out the
protected_branches.mastersection in.asf.yaml. Once merged, ASF's puppet bot will sync the configuration to GitHub and remove the protection rule (typically within minutes).Plan
master(and tags)protected_branches.masterconfigurationPrecedent
This same mechanism has been used multiple times historically (see commits
9d8fd0372,831d80b63,613c3b884).Test plan
masterbranch protection is removed viagh api repos/apache/linkis/branches/master🤖 Generated with Claude Code