Improve robustness when logging large message strings#593
Merged
Conversation
…maximum field length
…maximum field length
rm5248
reviewed
Feb 11, 2026
| void FormattingInfo::format(const int fieldStart, LogString& buffer) const | ||
| { | ||
| int rawLength = int(buffer.length() - fieldStart); | ||
| if (INT_MAX < buffer.length()) |
Contributor
There was a problem hiding this comment.
isn't this always going to be true? or am I misreading it?
Contributor
There was a problem hiding this comment.
wait no I'm misreading it, nevermind. The comparison is backwards from what I would typically do(if buffer.length() > INT_MAX)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces #584 by providing a more comprehensive approach when the application tries to log a very large string message