Fix NPE in ConfigurationScheduler by ensuring scheduledFuture is chec…#4118
Open
ramanathan1504 wants to merge 1 commit into
Open
Fix NPE in ConfigurationScheduler by ensuring scheduledFuture is chec…#4118ramanathan1504 wants to merge 1 commit into
ramanathan1504 wants to merge 1 commit into
Conversation
…ked for null before accessing its methods; add test for race condition in scheduling.
vy
requested changes
May 28, 2026
Member
vy
left a comment
vy
left a comment
There was a problem hiding this comment.
@ramanathan1504, please add a changelog entry too.
Member
There was a problem hiding this comment.
@ramanathan1504, test passes without your changes. Could you make sure this test fails without the fix?
Contributor
Author
There was a problem hiding this comment.
@vy , I restored the file log4j-core-test/src/test/java/org/apache/logging/log4j/core/config/ConfigurationScheduler.java. After doing so, the build succeeded—the test case passes perfectly without requiring any modifications to the source file.
github-project-automation
Bot
moved this to Changes requested
in Log4j pull request tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2073 existing Pr #3941
Fixed the NPE issue and added a test case for
ConfigurationScheduler