Remove invalid combine.self and combine.children attributes in mvnup#12160
Open
gnodet wants to merge 1 commit into
Open
Remove invalid combine.self and combine.children attributes in mvnup#12160gnodet wants to merge 1 commit into
gnodet wants to merge 1 commit into
Conversation
…f converting them Maven 3 silently ignored invalid combine.self and combine.children attribute values, so removing them entirely preserves actual Maven 3 behavior. Previously mvnup converted specific invalid values (e.g. combine.self="append" → "merge"), which could miss other invalid values and subtly changed semantics. Now both fixers detect any invalid value against the full set of valid values (combine.self: override/merge/remove; combine.children: append/merge), remove the attribute, and collect to a list before mutating to avoid potential stream processing issues. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
combine.selfandcombine.childrenattribute values entirely instead of converting them tomerge, since Maven 3 silently ignored invalid values — removing preserves actual Maven 3 behaviorcombine.self:override/merge/remove;combine.children:append/merge), not just specific ones likeappendoroverride.peek().count()pattern which could miss occurrencesTest plan
combine.self="append"and arbitrary invalid valuescombine.children="override"and arbitrary invalid valuesoverride,merge,removefor self;append,mergefor children) are preserved🤖 Generated with Claude Code