Conversation
When a remote parent POM declares a plugin with an explicit version in build/plugins (not via pluginManagement), adding a pluginManagement entry in the child is insufficient — the parent's explicit version takes precedence. The analysis now compares each plugin's effective version in build/plugins against build/pluginManagement/plugins: - Same version: version comes from PM, pluginManagement override works - Different version (or absent from PM): explicit version in parent's plugins, needs a direct build/plugins entry to override Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<build><plugins>(not via<pluginManagement>),mvnup's plugin upgrade strategy now correctly adds the override in<build><plugins>instead of only<pluginManagement>build/pluginsagainstbuild/pluginManagement/pluginsto determine upfront whether a<pluginManagement>override alone is sufficient or a direct<plugins>entry is needed<plugins>entries when the version is controlled via<pluginManagement>Supersedes #12157 and #12159.
Test plan
shouldNotAddDirectOverrideWhenVersionFromPluginManagementverifies no false-positive<plugins>entries fororg.apache:apache:23(version comes from PM)shouldNotDuplicatePluginInBuildPluginsWhenAlreadyDeclaredverifies no duplicates when plugin is already locally declared🤖 Generated with Claude Code