Skip to content

Fix deadlock in AbstractRequestCache.requests() due to unstable hashCode #12166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnodet wants to merge 1 commit into
base: maven-4.0.x
Choose a base branch
from
+2 −2
Open

Fix deadlock in AbstractRequestCache.requests() due to unstable hashCode #12166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions impl/maven-impl/src/main/java/org/apache/maven/impl/cache/AbstractRequestCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
package org.apache.maven.impl.cache;

import java.util.ArrayList;
import java.util.HashMap;
import java.util.IdentityHashMap;
import java.util.List;
import java.util.Map;
import java.util.function.Function;
Expand Down Expand Up @@ -85,7 +85,7 @@ public <REQ extends Request<?>, REP extends Result<REQ>> REP request(REQ req, Fu
@SuppressWarnings("unchecked")
public <REQ extends Request<?>, REP extends Result<REQ>> List<REP> requests(
List<REQ> reqs, Function<List<REQ>, List<REP>> supplier) {
final Map<REQ, Object> nonCachedResults = new HashMap<>();
final Map<REQ, Object> nonCachedResults = new IdentityHashMap<>();
List<RequestResult<REQ, REP>> allResults = new ArrayList<>(reqs.size());

Function<REQ, REP> individualSupplier = req -> {
Expand Down
Loading