MNG-11966: Update lifecycles reference to point to LifecycleRegistry#12260
MNG-11966: Update lifecycles reference to point to LifecycleRegistry#12260Hiteshsai007 wants to merge 6 commits into
Conversation
|
The The test environment runs with the On clean/uncached runners, this caused those helper invocations to run with RRF enabled, query Maven Central, and get blocked because I've added the disable flags directly in |
Why the old one failed:On Windows, the integration tests generated the How the new one works:The new parser checks for and strips the leading BOM ( |
|
Assessment is wrong, while Central prefixes really does not have And due assessment being wrong, the change in this PR is wrong as well. |
…elper calls" This reverts commit 5bc436c.
|
You are completely correct. The prefix matching in Maven Resolver allows I have reverted the changes to The actual root cause of the Windows-specific CI failures was the UTF-8 BOM ( |
|
Does UTF-8 care for endianness? How and why did BOM appear in your UTF-8 text file? |
No Sir, UTF-8 doesn't care about endianness at all. The BOM showed up because a lot of standard Windows tools (like Notepad or default PowerShell redirections) silently prepend the UTF-8 BOM to distinguish the file from legacy ANSI encoding. If a Windows user creates or edits their Since our parser wasn't stripping it, that invisible |
|
Given this is not the only file that Maven reads, let's remove this change from this PR (is out of scope for it anyway) and report a Maven issue where we can discuss this. |
Makes total sense! I've reverted the BOM-stripping changes in My only concern is that the Java 25 integration tests are expected to keep failing without that fix. Is there a preferred way to address those failures independently so this PR can still proceed? |
MNG-11966: Update lifecycles reference to point to LifecycleRegistry
Proposed Changes
This PR addresses issue #11966 ("Update documentation at - Introduction to the Build Lifecycle").
In PR #11916, legacy Plexus XML descriptors (
components.xmlanddefault-bindings.xml) were removed from themaven-coremodule as part of the migration of the core to JSR-330 /javax.inject.Consequently, the source file for the generated references page (
lifecycles.apt.vm) was still pointing to the old packageorg.apache.maven.lifecycle.providersfor the 3 lifecycles, which is no longer the source of truth.This change updates
lifecycles.apt.vmto point to the new publicorg.apache.maven.api.services.LifecycleRegistrywhere the lifecycles are registered and queried in Maven 4.Checklist
Your pull request should address just one issue, without pulling in other changes.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Each commit in the pull request should have a meaningful subject line and body.
Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. (N/A: Documentation-only change)
Run
mvn verifyto make sure basic checks pass. (N/A: Documentation-only change)You have run the Core IT successfully. (N/A: Documentation-only change)
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004