EL: improve resourcebundles handling#9177
Conversation
|
Updated and squashed, I think this is ready for review |
matthiasblaesing
left a comment
There was a problem hiding this comment.
I tested this with a minimal JSF project and that worked for me.
Looking through the changes I did not spot obvious problems and just have a minimal nitpick (see inline comment).
I have one more request. I normally would not request via a public forum, but I don't know whether a direct message via email would reach you. Please check your email inbox. There should be two emails with the same text regarding the Apache NetBeans Project (one from my personal email address and one from my @apache.org address), maybe these were lost in the SPAM folder.
enterprise/web.el/src/org/netbeans/modules/web/el/completion/ELCompletionUtil.java
Outdated
Show resolved
Hide resolved
|
One thing when I look at the commit, I'd like to ask you to update the commit message with the Intention. I would suggest: The commit message will be the element that people see in the history, so while the screenshot is very welcome here for illustration, for history the commit message is more important. |
651d90c to
25101b4
Compare
I updated the commit message |
… rendering The goto declaration implementation now does not directly jump to the base properties file, but give the use the option to choose the intent property file also offering the other language files. Rendering of the popup was updated and svg icons added.
25101b4 to
910ba08
Compare
|
Updated and squashed |
This is a follow-up to #8603


The main aim is enabling CTRL + Hover and CTRL + click on ResourceBundle items in JSF pages:
The features were already integrated in ELHyperlinkProvider but it seems GsfHyperlinkProvider has the precedence so I had to implement them in ELDeclarationFinder (which is called by GsfHyperlinkProvider).
Aside from that, I tried to improve the resource bundled loading here and there, using the built-in cache whenever possible.
This also includes: