Skip to content

[PHP] FIXES #9171 Return type not added to constructor override #9234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DamImpr wants to merge 3 commits into
base: master
Choose a base branch
from
+6 −3
Draft

[PHP] FIXES #9171 Return type not added to constructor override #9234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e153cd
Return type not added to constructor override
DamImpr Feb 26, 2026
7a4138f
Reduced the check to only the specific label "__construct", and not a…
DamImpr Mar 8, 2026
bbcecd3
Disabled return type generation in the constructor when generated wit…
DamImpr Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions php/php.editor/src/org/netbeans/modules/php/editor/completion/PHPCompletionItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1452,11 +1452,14 @@ protected String getNameAndFunctionBodyForTemplate() {
if (phpVersion != null
&& phpVersion.compareTo(PhpVersion.PHP_70) >= 0) {
Collection<TypeResolver> returnTypes = getBaseFunctionElement().getReturnTypes();
// check whether the method in question is the constructor. If it is, the return type should not be added.
boolean isConstructor = getBaseFunctionElement() instanceof MethodElement
&& ((MethodElement) getBaseFunctionElement()).getName().equals(MethodElement.CONSTRUCTOR_NAME);
// we can also write a union type in phpdoc e.g. @return int|float
// check whether the union type is actual declared return type to avoid adding the union type for phpdoc
if (returnTypes.size() == 1
if (!isConstructor && (returnTypes.size() == 1
|| getBaseFunctionElement().isReturnUnionType()
|| getBaseFunctionElement().isReturnIntersectionType()) {
|| getBaseFunctionElement().isReturnIntersectionType())) {
String returnType = getBaseFunctionElement().asString(PrintAs.ReturnTypes, typeNameResolver, phpVersion);
if (StringUtils.hasText(returnType)) {
boolean nullableType = CodeUtils.isNullableType(returnType);
Expand Down
2 changes: 1 addition & 1 deletion php/php.editor/src/org/netbeans/modules/php/editor/elements/BaseFunctionElementSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ public final String asString(PrintAs as, BaseFunctionElement element, TypeNameRe
Collection<TypeResolver> returns1 = getReturnTypes();
// we can also write the union type in phpdoc e.g. @return int|float
// check whether the union type is the actual declared return type to avoid adding the union type for phpdoc
if (returns1.size() == 1 || isReturnUnionType() || isReturnIntersectionType()) {
if (!element.getName().equals(MethodElement.CONSTRUCTOR_NAME) && returns1.size() == 1 || isReturnUnionType() || isReturnIntersectionType()) {
String returnType = asString(PrintAs.ReturnTypes, element, typeNameResolver, phpVersion);
if (StringUtils.hasText(returnType)) {
boolean isNullableType = CodeUtils.isNullableType(returnType);
Expand Down