Skip to content

Add all root project env files to ImportantFiles#9289

Open
haidubogdan wants to merge 1 commit intoapache:masterfrom
haidubogdan:t_add_all_env_files_to_important_files_node
Open

Add all root project env files to ImportantFiles#9289
haidubogdan wants to merge 1 commit intoapache:masterfrom
haidubogdan:t_add_all_env_files_to_important_files_node

Conversation

@haidubogdan
Copy link
Contributor

@haidubogdan haidubogdan commented Mar 22, 2026

Closes #9229

  • add all root project env files to ImportantFiles
  • additional coloring lexer fix for single quoted string with slash
  • remove envFileResolver service and replace it with a mime-resolver.xml to handle mime file association
  • all files containing .env. in their name are associated with text/x-env mimetype

Coloring fix for single quoted string

There was a escape done on slash inside strings, which created a small coloring issue.

Before:

image

After:

image

File association

Before:
.env.test and .env.local.demo were not under env mime type

image

After:

image

^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

Closes apache#9229

- additional coloring lexer fix for single quoted string with slash
- remove envFileResolver service and replace it with a mime-resolver.xml to handle mime file association
- all files containing .env. in their name are associated with text/x-env mimetype
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not all env files added to Important Files

1 participant