Skip to content

cmake:add lib_psa_set/getstackaddr file to CMakeLists.txt #17550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
anjiahao1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cmake:add lib_psa_set/getstackaddr file to CMakeLists.txt #17550

anjiahao1 wants to merge 1 commit into from

Conversation

@anjiahao1
Copy link
Contributor

@anjiahao1 anjiahao1 commented Dec 17, 2025

Summary

CMake forgot to compile these two files, so add them.

Impact

nothing,just add file to cmake

Testing

ci build

@github-actions github-actions bot added Area: OS Components OS Components issues Size: XS The size of the change in this PR is very small labels Dec 17, 2025
@simbit18
Copy link
Contributor

simbit18 commented Dec 17, 2025 •
edited
Loading

@anjiahao1 watch Make

https://github.com/anjiahao1/nuttx/blob/2952874e688ec44a982985e11cc9e6f0005c2b41/libs/libc/spawn/Make.defs#L33-L35

simbit18
simbit18 reviewed Dec 17, 2025
View reviewed changes
@anjiahao1
cmake:add lib_psa_set/getstackaddr file to CMakeLists.txt
0638784 
CMake forgot to compile these two files, so add them.

Signed-off-by: anjiahao <anjiahao@xiaomi.com>
@anjiahao1 anjiahao1 force-pushed the 20251217_cmake_stackattr branch from 2952874 to 0638784 Compare December 18, 2025 02:23
@simbit18
Copy link
Contributor

simbit18 commented Dec 18, 2025

@anjiahao1 please rebase the latest master to fix:
https://github.com/apache/nuttx/actions/runs/20323851306/job/58384997381#step:10:154

====================================================================================
Configuration/Tool: bl602evb/elf
2025-12-18 02:32:54
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Building NuttX...
riscv-none-elf-ld: cannot find /github/workspace/sources/nuttx/arch/risc-v/src/crt0.o: No such file or directory
make[4]: *** [Makefile:57: errno] Error 1
make[4]: Target 'install' not remade because of errors.

@acassis
Copy link
Contributor

acassis commented Dec 23, 2025

ping @anjiahao1 @xiaoxiang781216

Please rebase to fix the CI issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simbit18 simbit18 simbit18 left review comments

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

@raiden00pl raiden00pl Awaiting requested review from raiden00pl raiden00pl is a code owner

@acassis acassis Awaiting requested review from acassis

@jerpelea jerpelea Awaiting requested review from jerpelea

@linguini1 linguini1 Awaiting requested review from linguini1

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Area: OS Components OS Components issues Size: XS The size of the change in this PR is very small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anjiahao1 @simbit18 @acassis @xiaoxiang781216