Conversation
781cb65 to
d343504
Compare
|
PR check builds fail since apparenlty they add -Werror which means any of the now enabled unused parameter warnings require fixing before the check builds will succeed. |
|
@pbarada we should not add -Werr to the build. The reason is because a lot of kernel code has Edit: I see you just added -Wunused-parameter, I think that should be fine (?). @simbit18 and @lupyuen might know how to run the checks locally first. |
a1464f4 to
e3f4ff4
Compare
|
Rather than referencing address of arg in short circuited boolean expression (which can cause "always evaluates to true" at higher optimization levels), cast its arg to void. Signed-off-by: Peter Barada <peter.barada@gmail.com>
78177de to
1ae6105
Compare
|
Reverted PR to just change UNUSED() definition for arm gcc to cast arg to void. |
|
|
||
| # ifndef UNUSED | ||
| # define UNUSED(a) ((void)(1 || &(a))) | ||
| # define UNUSED(a) (void)(a) |
There was a problem hiding this comment.
please fix ALL places in this file
Update UNUSED() for arm builds
Summary
Note: This PR does not address all now-generated unused parameter warnings on ARM.
Impact
Testing
Build Host:
Target:
Testing performed:
Runtime testing: