boards: Fix modbus configs after moving it to apps/industry#18744
boards: Fix modbus configs after moving it to apps/industry#18744acassis wants to merge 1 commit intoapache:masterfrom
Conversation
|
It is funny, I was going to update the Documentation and discovery that is was already appointing to apps/industry/modbus: applications/examples/modbus/index.rst No idea how it happened :-D |
Actually it was @raiden00pl who predicted that it was going to happen! :-D |
|
@acassis I've had this on my TODO list for a long time :) |
|
Hmm, I made a mistake: I renamed the CONFIG_INDUSTRY_MODBUS directly inside defconfig,:
|
The modbus was moved to inside apps/industry, so these defconfigs need to be updated Signed-off-by: Alan C. Assis <acassis@gmail.com>
|
Hmm, I am wondering if Instead, if we plan to have different modbus implementations we could use something like For other implementations we would then use |
|
The problem with the current Kconfig is that we don't have any standardization for option names. Some programs/libs use one format, others another. The main (and probably the only disadvantage of INDUSTRY_MODBUS) is that the options become long, the advantage is that we have context added to the option name (like INDUSTRY). Personally, I would be in favor of the name |
Summary
The modbus was moved to inside apps/industry, so these defconfigs need to be updated
Impact
None, only organization
Testing
On NuttX board:
On Linux side: