HDDS-10283. [WIP] Apply zero copy to Ozone client reads#10369
Draft
smengcl wants to merge 7 commits into
Draft
Conversation
Install a ZeroCopyMessageMarshaller (from ratis-thirdparty) as the response marshaller for the XceiverClient.send bidi-stream RPC. The marshaller wraps the inbound Netty buffer as proto3 ByteString via UnsafeByteOperations.unsafeWrap, so the chunk-data field of a ReadChunk response no longer requires a chunk-sized memcpy on the client. Lifecycle: - ReadChunk responses keep the Netty buffer alive: ContainerProtocolCalls returns the outer ContainerCommandResponseProto so that ChunkInputStream can hold the reference until releaseBuffers() runs, at which point it calls XceiverClientSpi.releaseReceivedResponse to return the buffer to the pool. - All other response types are deep-copied inside the wrapping marshaller and the original buffer-aliased response is released immediately, so callers never observe an aliased non-ReadChunk response and the marshaller's tracking map does not grow without bound. - If a sendCommand validator throws, the response is released in a finally block before the exception propagates. Mirrors the existing server-side request-side zero-copy pattern in GrpcXceiverService.bindServiceWithZeroCopy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated-by: Claude Code (Opus 4.7)
Generated-by: Codex (GPT-5.4)
Finishing what @duongkame left off.
What changes were proposed in this pull request?
ReadChunkpath for client reads.readChunk()path unchanged for compatibility.Mirrors the existing server-side request-side zero-copy pattern in GrpcXceiverService.bindServiceWithZeroCopy.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10283
How was this patch tested?